Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server SHOULD send full-sized datagrams until the path is validated #4188
Server SHOULD send full-sized datagrams until the path is validated #4188
Changes from 1 commit
6e76817
1214c15
78500d1
5727b87
56569b9
8ec73e1
97b8798
bd089c9
271010c
a3351be
0410b60
6e0fe53
681c02e
34ad874
c30347b
67e49f8
3518d54
a51ad56
1bb33b1
3f875ca
e3a596f
c550cb4
adbe600
8f5dff7
b1ab5f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be worth highlighting the 'ping-pong' risk, so I tried to do that without using those words.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the packet reflection this is well-enough explained to use it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of @ianswett's suggestion.
The principles we have for preventing ping-pong are:
This paragraph is talking when an endpoint MAY violate those rules. Therefore, IMO it is good to point out that risk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather add:
There are other reasons why this might happen (hitting an endpoint that thinks it closed, for example.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 3518d54, applied changes suggested by @ianswett to the existing sentence.
In a51ad56, added the rationale suggested by @martinthomson with tweaks. Specifically, I changed the subject to "endpoints" so that it would be generic, and used "back off", as we suggest using that for Stateless Resets, etc.
PTAL.