Clear up confusion about label encoding #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was, I think clear, but the use of HKDF-Expand-Label and the encoding of labels into octets could be even more explicit. Closes #4197.
martinthomson
added
editorial
seanturner
approved these changes
Oct 14, 2020
gloinul
approved these changes
Oct 15, 2020
janaiyengar
approved these changes
Oct 15, 2020
| be used with QUIC. | ||
| cipher suite. Note that labels, which are described using strings, are encoded | ||
| as bytes using ASCII {{?ASCII=RFC0020}} without quotes or any trailing NUL | ||
| byte. Other versions of TLS MUST provide a similar function in order to be |
There was a problem hiding this comment.
Suggested change
| byte. Other versions of TLS MUST provide a similar function in order to be | |
| bytes. Other versions of TLS MUST provide a similar function in order to be |
There was a problem hiding this comment.
This is singular intentionally, to avoid problems like might arise from:
const char* label = "quic key";
hkdf_expand_label(...., label, strlen(label), ...);
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was, I think clear, but the use of HKDF-Expand-Label and the
encoding of labels into octets could be even more explicit.
Closes #4197.