Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's an HTTP/3 connection? #4212

Merged
merged 3 commits into from Oct 16, 2020
Merged

What's an HTTP/3 connection? #4212

merged 3 commits into from Oct 16, 2020
+81 −74

Conversation

MikeBishop
Copy link
Contributor

Fixes #4206.

ianswett
ianswett approved these changes Oct 14, 2020
View reviewed changes
draft-ietf-quic-http.md Show resolved Hide resolved
martinthomson
martinthomson approved these changes Oct 14, 2020
View reviewed changes
draft-ietf-quic-http.md Show resolved Hide resolved
@larseggert larseggert mentioned this pull request Oct 15, 2020
Closed
gloinul
gloinul reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@gloinul gloinul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the Issue there likely need to be a review of the 200+ times the word "connection" is used in the document to determine if one need to stress that it is the HTTP/3 connection or some other connection.

janaiyengar
janaiyengar approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of suggestions

draft-ietf-quic-http.md Outdated Show resolved Hide resolved
draft-ietf-quic-http.md Outdated Show resolved Hide resolved
@martinthomson martinthomson added -http editorial An issue that does not affect the design of the protocol; does not require consensus. labels Oct 15, 2020
@MikeBishop @janaiyengar
Apply suggestions from code review
043e1b8 
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@MikeBishop MikeBishop merged commit a33d2ec into master Oct 16, 2020
@MikeBishop MikeBishop deleted the http/define-h3-connection branch October 16, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPardue LPardue LPardue left review comments

@gloinul gloinul gloinul left review comments

@martinthomson martinthomson martinthomson approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP-31: HTTP/3 Connection definition?
6 participants
@MikeBishop @martinthomson @LPardue @janaiyengar @gloinul @ianswett