Prohibit using old keys for sending #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this context, "newer" was confusing as the code permits the creation of the next set of packet protection keys when switching over. As the goal of the text was to ensure that old keys not be used, using that formulation avoids any confusion that might be caused from not having a reference against which to decide which is "newer". Closes #4199.
martinthomson
added
editorial
ianswett
approved these changes
Oct 15, 2020
janaiyengar
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
@gloinul's request was quite clear, so you should merge this and close the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this context, "newer" was confusing as the code permits the creation
of the next set of packet protection keys when switching over. As the
goal of the text was to ensure that old keys not be used, using that
formulation avoids any confusion that might be caused from not having a
reference against which to decide which is "newer".
Closes #4199.