Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precision in defining string literals #4249

Merged
merged 2 commits into from Oct 19, 2020
Merged

Conversation

MikeBishop
Copy link
Contributor

Fixes #4244

@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -qpack labels Oct 19, 2020
Comment on lines 661 to 662
begin other than on a byte boundary. An "N-bit prefix string literal" begins in
mid-byte, with the first (8-N) bits allocated to a previous field. The string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 'begins mid-byte' read better than 'begins in mid-byte'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does to me

@afrind afrind merged commit b34a8d5 into master Oct 19, 2020
@afrind afrind deleted the qpack/string_specifics branch October 19, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QPACK-18: Encoding of string literals
3 participants