Reduce the number of offset lengths in a stream frame #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
approved these changes
Apr 13, 2017
draft-ietf-quic-transport.md
Outdated
| These bits are parsed as follows: | ||
|
|
||
| * The leftmost bit must be set to 1, indicating that this is a STREAM frame. | ||
| * The first two bit must be set to 11, indicating that this is a STREAM frame. |
draft-ietf-quic-transport.md
Outdated
|
|
||
| * The first two bits must be set to 01 indicating that this is an ACK frame. | ||
| * The first two bits must be set to 101 indicating that this is an ACK frame. |
martinthomson
added
design
|
I was a little surprised to see this change was merged. @ianswett, this change to the transport doc wasn't reviewed by either @janaiyengar or myself; nor do I see any discussion on the list. In this case, I think that it's a big improvement, so I've no objection, but I don't think we should be merging changes to documents without the approval of at least one editor. (And sorry for not reviewing this, I don't know how I missed it.) |
|
I remember Jana and I discussing it, but next time I'll make sure one of you approves it on Github. |
|
:) If Jana said it's OK, that's fine. I also think that it's OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #414