Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error code for when the path fails #4331

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

martinthomson
Copy link
Member

This is a bit of a niche code, as it is only narrowly useful for
signaling loss of paths. But people wanted it and it doesn't code that
much.

Note the target of this pull request.

For #4257.

This is a bit of a niche code, as it is only narrowly useful for
signaling loss of paths.  But people wanted it and it doesn't code that
much.

For #4257.
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Nov 5, 2020
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, but lgtm

draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@martinthomson
Copy link
Member Author

I'm going to leave this for a bit, but if people like the idea, I plan to merge it into #4264.

Copy link
Member

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

This error code will be useful, as the only other way of closing the connection would be to use NO_ERROR. Then, it would be impossible to know why the connection was abruptly closed.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there's value in having a way to fail fast.

draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
Co-authored-by: Mike Bishop <mbishop@evequefou.be>
@martinthomson martinthomson merged commit bbc0711 into migration-amplification Nov 5, 2020
@martinthomson martinthomson deleted the no-viable-path branch November 5, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants