Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of editorial cleanup. Short summary: #438

Closed
wants to merge 2 commits into from
Closed

A bunch of editorial cleanup. Short summary: #438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f3c7b
A bunch of editorial cleanup. Short summary:
ekr Apr 13, 2017
e62936d
Martin's comments
ekr Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions draft-ietf-quic-tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,7 @@ For example, the client packet protection secret uses an info parameter of:
"TLS 1.3, QUIC client 1-RTT secret" || 0x00
~~~


### Packet Protection Key and IV

The complete key expansion uses an identical process for key expansion as
Expand All @@ -726,20 +727,18 @@ the input secret. QUIC uses the AEAD function negotiated by TLS.
The packet protection key and IV used to protect the 0-RTT packets sent by a
client are derived from the QUIC 0-RTT secret. The packet protection keys
and IVs for 1-RTT packets sent by the client and server are derived from
the current generation of client_pp_secret and server_pp_secret respectively,
as shown below:

~~~
key = HKDF-Expand-Label(S, "key", "", key_length)
iv = HKDF-Expand-Label(S, "iv", "", iv_length)
~~~

the current generation of client_pp_secret and server_pp_secret respectively.
The length of the output is determined by the requirements of the AEAD function
selected by TLS. The key length is the AEAD key size. As defined in Section
5.3 of {{!I-D.ietf-tls-tls13}}, the IV length is the larger of 8 or N_MIN (see
Section 4 of {{!RFC5116}}). For any secret S, the corresponding key and
IV are derived as shown below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an above, but not below.

I think that you mean to move the above code block to below this paragraph and remove the "as shown below:" from the previous one.


~~~
key = HKDF-Expand-Label(S, "key", "", key_length)
iv = HKDF-Expand-Label(S, "iv", "", iv_length)
~~~

The QUIC record protection initially starts without keying material. When the
TLS state machine reports that the ClientHello has been sent, the 0-RTT keys can
be generated and installed for writing. When the TLS state machine reports
Expand Down