-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework lots of error references #4384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is already helpful. I would like the text to be yet a bit more explicit, see my suggestions.
Also, could you add another reference to {{errors}} where you first mention error codes, i.e., after "error code H3_REQUEST_INCOMPLETE" in Section 4.1 (at the bottom of page 12 in -32), please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thank mike
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
Fixes #4352.
Expands on error handling discussion and clarifies difference from HTTP status codes which indicate error response. Also, some editorial consistency fixes:
I've done a sweep and believe these are consistent now.
@theri, your review would be appreciated.