Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework lots of error references #4384

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Rework lots of error references #4384

merged 3 commits into from
Nov 24, 2020

Conversation

MikeBishop
Copy link
Contributor

Fixes #4352.

Expands on error handling discussion and clarifies difference from HTTP status codes which indicate error response. Also, some editorial consistency fixes:

  • The references to errors seem to have missed our switch to use "; see XXXX." where possible.
  • Somewhere along the way, we stopped referring to the error handling section when defining errors.

I've done a sweep and believe these are consistent now.

@theri, your review would be appreciated.

Copy link

@renghardt renghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is already helpful. I would like the text to be yet a bit more explicit, see my suggestions.

Also, could you add another reference to {{errors}} where you first mention error codes, i.e., after "error code H3_REQUEST_INCOMPLETE" in Section 4.1 (at the bottom of page 12 in -32), please?

draft-ietf-quic-http.md Outdated Show resolved Hide resolved
draft-ietf-quic-http.md Outdated Show resolved Hide resolved
draft-ietf-quic-http.md Outdated Show resolved Hide resolved
Copy link

@renghardt renghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

draft-ietf-quic-http.md Outdated Show resolved Hide resolved
Copy link
Member

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank mike

Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@MikeBishop MikeBishop merged commit 97b770e into master Nov 24, 2020
@MikeBishop MikeBishop deleted the http/how_errors_work branch November 24, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP concepts of error codes
7 participants