Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport parameters can be used before they are authentic #4463

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

martinthomson
Copy link
Member

This is OK, but only in a limited fashion.

This is OK, but only in a limited fashion.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -tls labels Dec 23, 2020
Copy link
Contributor

@seanturner seanturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes add clarity.

@LPardue LPardue linked an issue Dec 29, 2020 that may be closed by this pull request
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the limitations could be a be clearer, but heading in a good direction.

and reliance on them should be minimized. However, any tampering with the
parameters will cause the handshake to fail.
Transport parameters become available prior to the completion of the handshake.
Using these values earlier than handshake completion is necessary at the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's necessary to send 1-RTT packets prior to handshake completion, but it is necessary to send many things, such as data on streams in 0.5RTT packets.

Also, the way this is written, it could be read as sending 1-RTT packets from server to client requires using these values prior to handshake completion, which I realize isn't your intent.

draft-ietf-quic-tls.md Outdated Show resolved Hide resolved
martinthomson and others added 2 commits January 7, 2021 20:46
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@martinthomson martinthomson merged commit 4748fc6 into master Jan 11, 2021
@martinthomson martinthomson deleted the tp-availability branch January 11, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Martin Duke TLS Comment 1
5 participants