Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say that this version is 1 #4587

Merged
merged 2 commits into from Jan 7, 2021
Merged

Say that this version is 1 #4587

merged 2 commits into from Jan 7, 2021

Conversation

martinthomson
Copy link
Member

It was pretty obtuse otherwise.

Closes #4529.

@martinthomson
Say that this version is 1
574aabb 
It was pretty obtuse otherwise.

Closes #4529.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 6, 2021
janaiyengar
janaiyengar approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@martinthomson @janaiyengar
not a number
9ef8b23 
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@janaiyengar janaiyengar merged commit b70c906 into master Jan 7, 2021
@janaiyengar janaiyengar deleted the this-version-is-1 branch January 7, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@MikeBishop MikeBishop MikeBishop approved these changes

@DavidSchinazi DavidSchinazi DavidSchinazi approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Éric Vyncke's Transport Comment 6
6 participants
@martinthomson @marten-seemann @MikeBishop @DavidSchinazi @janaiyengar @ianswett