Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't know how to hyphenate packet type specific #4705

Merged
merged 1 commit into from Jan 11, 2021
Merged

I don't know how to hyphenate packet type specific #4705

merged 1 commit into from Jan 11, 2021

Conversation

martinthomson
Copy link
Member

So I rewrote the sentence instead.

Closes #4680.

@martinthomson
I don't know how to hyphenate packet type specific
a1d5f94 
So I rewrote the sentence instead.

Closes #4680.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 8, 2021
@marten-seemann
Copy link
Contributor

packet-type-specific?

janaiyengar
janaiyengar approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, you can simply do "type specific", since type-specific is not an adjective before a noun (like "type-specific bits"). But this is good too.

@janaiyengar janaiyengar merged commit a446b2d into master Jan 11, 2021
@janaiyengar janaiyengar deleted the packet-type-specific branch January 11, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robert Wilton's Transport Comment 13
4 participants
@martinthomson @marten-seemann @janaiyengar @ianswett