Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taken from, not defined in #4718

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Taken from, not defined in #4718

merged 2 commits into from
Jan 12, 2021

Conversation

MikeBishop
Copy link
Contributor

Fixes #4550
Fixes #4551

This makes it clearer that the notation is copied from v1, not defined there and normatively referenced. (Note, figures aren't normative anyway.)

janaiyengar
janaiyengar reviewed Jan 11, 2021
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format is defined here anyway, so there's no reason to suggest primacy. I've suggested a simpler wording.

draft-ietf-quic-invariants.md Outdated Show resolved Hide resolved
martinthomson
martinthomson reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other bids?

draft-ietf-quic-invariants.md Outdated Show resolved Hide resolved
@martinthomson martinthomson added -invariants editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jan 11, 2021
@martinthomson martinthomson merged commit 05ea410 into master Jan 12, 2021
@martinthomson martinthomson deleted the invariants/import_notation branch January 12, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson left review comments

@janaiyengar janaiyengar janaiyengar left review comments

Assignees
No one assigned
Labels
-invariants editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Éric Vyncke's Invariants Comment 5 Éric Vyncke's Invariants Comment 4
3 participants
@MikeBishop @martinthomson @janaiyengar