Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTO is restarted on handshake confirmation #4734

Merged
merged 3 commits into from Jan 13, 2021
Merged

PTO is restarted on handshake confirmation #4734

merged 3 commits into from Jan 13, 2021

Conversation

janaiyengar
Copy link
Contributor

Closes #4710.

martinthomson
martinthomson approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

ianswett
ianswett requested changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, since when Initial or Handshake keys are discarded, if the PTO was set based on one of those PN spaces, clearly the PTO would need to be reset.

@martinthomson martinthomson added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jan 13, 2021
@martinthomson
Copy link
Member

Ian is right, we would lose the Initial discard condition. Drop the Handshake key drop condition.

@janaiyengar
Copy link
Contributor Author

@ianswett -- you're right, but I think that only applies to Initial here, since hs confirmed is the same as hs keys getting dropped. Take a look at the new text.

@janaiyengar janaiyengar merged commit 7fbf6af into master Jan 13, 2021
@janaiyengar janaiyengar deleted the confirmation branch January 13, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ben Kaduk's Recovery Comment 3
3 participants
@janaiyengar @martinthomson @ianswett