Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not unauthenticated, but those that cannot be processed #4736

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Not unauthenticated, but those that cannot be processed #4736

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe44101
sync
janaiyengar Jan 12, 2021
b411aee
Not unauthenticated, but packets it cannot process
janaiyengar Jan 12, 2021
c92b4b3
Update draft-ietf-quic-recovery.md
janaiyengar Jan 12, 2021
33b5a53
revert unprocessable packets
janaiyengar Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,12 +683,12 @@ client receives Handshake or 1-RTT packets prior to obtaining Handshake keys,
it may assume some or all of the server's Initial packets were lost.

To speed up handshake completion under these conditions, an endpoint MAY, for a
limited number of occasions per each connection, send a packet containing
limited number of times per connection, send a packet containing
unacknowledged CRYPTO data earlier than the PTO expiry, subject to the address
validation limits in Section 8.1 of {{QUIC-TRANSPORT}}. Doing so at most once
for each connection is adequate to quickly recover from a single packet loss.
Endpoints that do not cease retransmitting packets in response to
unauthenticated data risk creating an infinite exchange of packets.
An endpoint that always retransmits packets in response to receiving packets
that it cannot process risks creating an infinite exchange of packets.
Comment on lines +690 to +691
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An endpoint that always retransmits packets in response to receiving packets
that it cannot process risks creating an infinite exchange of packets.
An endpoint that always retransmits packets in response to receiving
unprocessable packets risks creating an infinite exchange of packets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that this changes what an endpoint cannot do right now to a property of the packets. I'm reverting this change.


Endpoints can also use coalesced packets (see Section 12.2 of
{{QUIC-TRANSPORT}}) to ensure that each datagram elicits at least one
Expand Down