Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If client detects error #4829

Merged
merged 1 commit into from Feb 18, 2021
Merged

If client detects error #4829

merged 1 commit into from Feb 18, 2021

Conversation

MikeBishop
Copy link
Contributor

@MikeBishop MikeBishop commented Feb 17, 2021 •
edited

Adds the all-important conditional.

Fixes #4828.

@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -http labels Feb 17, 2021
@LPardue LPardue mentioned this pull request Feb 17, 2021
Closed
martinthomson
martinthomson approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution :)

@MikeBishop MikeBishop merged commit 68a7325 into master Feb 18, 2021
@MikeBishop MikeBishop deleted the http/if-detect branch February 18, 2021 16:41
@MikeBishop MikeBishop restored the http/if-detect branch February 18, 2021 16:41
@MikeBishop MikeBishop deleted the http/if-detect branch March 30, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@guoye-zhang guoye-zhang guoye-zhang approved these changes

@LPardue LPardue LPardue approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rejecting duplicated push streams requirement is unenforceable
5 participants
@MikeBishop @martinthomson @guoye-zhang @LPardue @ianswett