Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ACK-eliciting packets in flight to identify anti-deadlock probes #4848

Merged
merged 6 commits into from
Mar 30, 2021
Merged

Use ACK-eliciting packets in flight to identify anti-deadlock probes #4848

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b63bc5a
Use ACK-eliciting packets in flight to identify anti-deadlock probes
Ralith Mar 21, 2021
2bd9bb1
Flip condition around for consistency
Ralith Mar 22, 2021
33c19b1
Tweak comment
Ralith Mar 22, 2021
6942fde
Adjust packet space scan to match
Ralith Mar 23, 2021
9520825
Fix old typo
Ralith Mar 23, 2021
660d8d2
Reword comment
Ralith Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,12 +1557,7 @@ OnLossDetectionTimeout():
SetLossDetectionTimer()
return

if (any ack-eliciting packets in flight):
// PTO. Send new data if available, else retransmit old data.
// If neither is available, send a single PING frame.
_, pn_space = GetPtoTimeAndSpace()
SendOneOrTwoAckElicitingPackets(pn_space)
else:
if (no ack-eliciting packets in flight):
assert(!PeerCompletedAddressValidation())
// Client sends an anti-deadlock packet: Initial is padded
// to earn more anti-amplification credit,
Expand All @@ -1571,6 +1566,11 @@ OnLossDetectionTimeout():
SendOneAckElicitingHandshakePacket()
else:
SendOneAckElicitingPaddedInitialPacket()
else:
// PTO. Send new data if available, else retransmit old data.
// If neither is available, send a single PING frame.
_, pn_space = GetPtoTimeAndSpace()
SendOneOrTwoAckElicitingPackets(pn_space)

pto_count++
SetLossDetectionTimer()
Expand Down