New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC text changes for -tls #4875
Merged
Merged
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
917ff79
First set of RPC edits for TLS
martinthomson 9dc9834
RPC text changes for -tls
martinthomson 48e7ff8
Use lowercase for Application Data
martinthomson 401dc24
Use inclusive language
martinthomson 127e104
as follows
martinthomson 0db7cd0
Add sourcecode labels as necessary
martinthomson ce79971
Use <aside> for notes
martinthomson 3784d73
Merge branch 'tls-aside' into rpc-tls
martinthomson 139fdc4
Reword packet protection sampling allowance text
martinthomson f3a644d
reword key randomization rationale
martinthomson 1890c73
Add expanded CCM-ANALAYSIS reference
martinthomson 8710f3d
Add markdown=block to aside elements
martinthomson 6937fd0
Full reference for NAN
martinthomson ea0eed4
Build the XML for the table manually
martinthomson 73ad59a
Missed GCM-MU
martinthomson a67dd5d
Remove redundant <t> elements
martinthomson 34e25db
thean
martinthomson 616f5f3
Merge branch 'master' into rpc-tls
martinthomson 074a7e3
Rewrite to avoid awkward line break
martinthomson ba4104d
Merge branch 'tls-wrap-exponent' into rpc-tls
martinthomson File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't quite seem right. How about "bogus", "arbitrary", "fake"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Randomizing is how you have to make such a key. Arbitrary suggests that
return 4;
[citation] is OK, when it definitely isn't. If you don't use strong randomness, then an attacker might be able to convince you to accept their input.(You can fold the fact that the key is bogus in to the final assessment, but that changes the scope of code that needs to be constant time, which is much easier to mess up than just using good randomness.)
I'd suggest including more text on this, but it's not really a good time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarifying -- now that I understand this better, I'm happy with the text.