Recovery RFCEditor #3: Why reset min_rtt #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find this easier to read, but I think it may be subtly different, so I put it into a separate PR. |
MikeBishop
reviewed
May 6, 2021
Co-authored-by: Mike Bishop <mbishop@evequefou.be>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
janaiyengar
approved these changes
May 7, 2021
rfc9002.md
Outdated
| of min_rtt and smoothed_rtt ({{smoothed-rtt}}) after a disruptive network event, | ||
| and because it is possible that an increase in path delay resulted in persistent | ||
| congestion being incorrectly declared. | ||
| congestion is established. This helps when an increase in path delay |
There was a problem hiding this comment.
Helps what?
The key is that it avoids repeatedly entering persistent congestion if the path RTT has genuinely increased.
ianswett
commented
May 11, 2021
martinthomson
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current:
Endpoints SHOULD set the min_rtt to the newest RTT sample after
persistent congestion is established. This is to allow a connection
to reset its estimate of min_rtt and smoothed_rtt after a
disruptive network event (Section 5.3), and because it is possible
that an increase in path delay resulted in persistent congestion
being incorrectly declared.
Perhaps:
Endpoints SHOULD set the min_rtt to the newest RTT sample after
persistent congestion is established because it is possible that
an increase in path delay resulted in persistent congestion being
incorrectly declared. This also allows a connection to reset its
estimate of min_rtt and smoothed_rtt after a disruptive network
event (Section 5.3).