All the missing pieces in RFC 9000 that I found #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
the
editorial
martinthomson
force-pushed
the
missing-rfc9000-bits
branch
from
b7cb663
to
f520a5f
Compare
MikeBishop
approved these changes
May 12, 2021
rfc9000.md
Outdated
| @@ -1382,7 +1382,7 @@ when a client's address changes. | |||
|
|
|||
| A server in a deployment that does not implement a solution to maintain | |||
| connection continuity when the client address changes SHOULD indicate that | |||
| migration is not supported by using the disable_active_migration transport | |||
There was a problem hiding this comment.
@janaiyengar explicitly added this "by" in 4601579.
There was a problem hiding this comment.
Yup -- @MikeBishop added "that" on line 1384, which I think makes this "by" necessary.
rfc9000.md
Outdated
| @@ -1829,7 +1829,7 @@ constraints conflict. | |||
|
|
|||
| Using 0-RTT depends on both client and server using protocol parameters that | |||
| were negotiated from a previous connection. To enable 0-RTT, endpoints store | |||
| the values of the server transport parameters with any session tickets it | |||
| the value of the server transport parameters with any session tickets it | |||
There was a problem hiding this comment.
This seems inconsistent with the remainder of the paragraph and following, where we talk about "values" for the individual parameters.
janaiyengar
approved these changes
May 13, 2021
rfc9000.md
Outdated
| @@ -1382,7 +1382,7 @@ when a client's address changes. | |||
|
|
|||
| A server in a deployment that does not implement a solution to maintain | |||
| connection continuity when the client address changes SHOULD indicate that | |||
| migration is not supported by using the disable_active_migration transport | |||
There was a problem hiding this comment.
Yup -- @MikeBishop added "that" on line 1384, which I think makes this "by" necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.