Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stream state machine #623

Merged
merged 4 commits into from
Jun 13, 2017
Merged

Fix stream state machine #623

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
449f432
Fix stream state machine
martinthomson Jun 10, 2017
07dedce
Fix 571 properly
martinthomson Jun 10, 2017
b187587
Allow for RST_STREAM more explicitly.
martinthomson Jun 10, 2017
bb6cee1
Remove the requirement to have stream data acknowledged for close
martinthomson Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2432,7 +2432,7 @@ stream data and a STREAM frame with a FIN flag, including any retransmissions,
the stream state becomes "half-closed (local)". When an endpoint receives all
stream data a FIN flag the stream state becomes "half-closed (remote)". An
endpoint MUST NOT consider the stream state to have changed until all data has
either been acknowledged or received.
been acknowledged, received or discarded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "arrived" was deliberate -- the stream does not need to hang around in open state until all data is acked. That's a matter of reliability, which should not have anything to do with stream states. I would like to keep stream states decoupled from reliability requirements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that you revert the changes that require receipt of acks for sent data for streams to transition to closed. The other changes LGTM.


A RST_STREAM frame on an "open" stream causes the stream to become
"half-closed". A stream that becomes "open" as a result of sending or receiving
Expand Down