Clarify how connection ID can be omitted #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of the truncate_connection_id was correct, but the name was poor (it implied that part of the connection ID was included) and it wasn't referenced from the critical part of the document (the short header definition). This corrects both of those oversights. Closes #659.
martinthomson
added
-transport
editorial
ianswett
reviewed
Jun 28, 2017
draft-ietf-quic-transport.md
Outdated
| set to 0, the Connection ID field is omitted. | ||
| set to 0, the Connection ID field is omitted. The Connection ID field can | ||
| only be omitted if the omit_connection_id transport parameter | ||
| ({{transport-parameter-definitions}}) is used by the intended recipient of the |
There was a problem hiding this comment.
nit: By used, do you mean negotiated?
There was a problem hiding this comment.
This isn't really a negotiation. Each endpoint indicates whether it will accept a packet that omits connection ID. Nothing that its peer says will change that. "Used" is perhaps a little too generic, but would "includes" work?
There was a problem hiding this comment.
Includes is ok, but maybe "supplied" or "specified"?
ianswett
approved these changes
Jun 28, 2017
ianswett
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of the truncate_connection_id was correct, but the name
was poor (it implied that part of the connection ID was included) and it
wasn't referenced from the critical part of the document (the short
header definition). This corrects both of those oversights.
Closes #659.