New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP requests on one stream #692
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
eab1b26
Everything on one stream (beware HPACK)
MikeBishop 404c5b8
Replace HPACK Sequence with zero dynamic table size
MikeBishop b5a4d74
Pushes aren't sequential
MikeBishop c2d5711
Merge remote-tracking branch 'origin/master' into one_stream
MikeBishop 9c4eb18
SHOULD be sequential
MikeBishop 97b5d40
utilize and reset
MikeBishop File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -200,9 +200,9 @@ this MUST be treated as a connection error (see HTTP_MALFORMED_* in | |
{{http-error-codes}}). Streams which terminate abruptly may do so at any point | ||
in the frame. | ||
|
||
Streams used for requests MUST be utilized sequentially, with no gaps. Streams | ||
used for pushed resources MAY be initiated out-of-order, but stream IDs SHOULD | ||
be allocated to promised resources sequentially. | ||
Streams SHOULD be utilized sequentially, with no gaps. Streams used for pushed | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not new in this PR, but sure. |
||
resources MAY be initiated out-of-order, but stream IDs SHOULD be allocated to | ||
promised resources sequentially. | ||
|
||
HTTP does not need to do any separate multiplexing when using QUIC - data sent | ||
over a QUIC stream always maps to a particular HTTP transaction. Requests and | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear here what you mean by "terminate abruptly". Do you mean that the stream is reset, or do you mean termination in some other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the transport draft, RST_STREAM is used "to abruptly terminate a stream." Basically, I'm saying don't worry about truncated frames in the event of resets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the word "reset" then