Size limit for Version Negotiation #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, the limits are largely practical, and there should be enough incentive to avoid inflation, but it pays to be a little more precise when defining protocols or you can get odd downstream effects. I've chosen to limit the size to the CI. That's 1200 currently (or more) and should be plenty og space for many versions. Closes #585.
martinthomson
added
-transport
editorial
MikeBishop
approved these changes
Sep 6, 2017
draft-ietf-quic-transport.md
Outdated
| @@ -887,6 +887,13 @@ server discards the incoming packet and responds with a Version Negotiation | |||
| packet ({{packet-version}}). This includes a list of versions that the server | |||
| will accept. | |||
|
|
|||
| There is no limit to the size of the Version Negotiation packet, other than the | |||
| number of versions that the server supports and the estimated path MTU. To | |||
There was a problem hiding this comment.
Since the point of this change is to impose a limit, this first sentence seems contradictory. I'd just drop it.
janaiyengar
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, the limits are largely practical, and there should be enough
incentive to avoid inflation, but it pays to be a little more precise when
defining protocols or you can get odd downstream effects. I've chosen to limit
the size to the CI. That's 1200 currently (or more) and should be plenty og
space for many versions.
Closes #585.