Add OnPacketSentCC #780
Merged
Add OnPacketSentCC #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve pacing text and remove pacing pseudocode.
janaiyengar
approved these changes
Sep 19, 2017
| slow start. | ||
| slow start. In order to fairly compete with flows that are not pacing, | ||
| it is recommended to not pace the first 10 sent packets when exiting | ||
| quiescence. |
There was a problem hiding this comment.
I wonder if this entire section should be removed and left to implementers. But this is fine for now, let's discuss that separately.
nibanks
reviewed
Sep 19, 2017
| @@ -693,22 +702,35 @@ follows: | |||
| ssthresh = infinite | |||
| ~~~ | |||
|
|
|||
| ### On Packet Sent | |||
|
|
|||
| Whenever a packet is sent, and is contains non-ACK frames, | |||
There was a problem hiding this comment.
Instead of and is contains non-ACK frames, I assume you mean and it contains non-ACK frames,?
|
Thanks for the comments Nick, I'll try to make sure those end up in my next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve pacing text and remove pacing pseudocode.