Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Integration Error Nits #787

Closed
wants to merge 1 commit into from
Closed

HTTP Integration Error Nits #787

wants to merge 1 commit into from

Conversation

mcmanus
Copy link
Contributor

@mcmanus mcmanus commented Sep 21, 2017

  • error code space is 30 bits
  • error codes can be used with stop_sending
  • genericized CANCEL to indicate it can be used bidirectionally

@mcmanus
HTTP Integration Error Nits
e40a044 
  * error code space is 30 bits
  * error codes can be used with stop_sending
  * genericized CANCEL to indicate it can be used bidirectionally
martinthomson
martinthomson approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this if I wasn't planning to obsolete them immediately with #722.

@MikeBishop
Copy link
Contributor

Merged the non-obsolete bit manually.

@MikeBishop MikeBishop closed this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcmanus @MikeBishop @martinthomson