Tweaks for the draining period #870
Conversation
This makes the 3RTO timer advisory (SHOULD). It also adds a note about leaving early. If you can be sure that the other side isn't going to send you more packets indefinitely, then you can end early if you are OK with receiving reordered or delayed packets. I also removed a residual mention of sending ACK frames in this state.
|
This just seems like a hack for failing to acknowledge that there are times when draining is required and times when it's not. I'd like to see this whole section revisited rather than continuing to add epicycles. |
|
It sounds like you have higher-level concerns than this. If you could write them up in an issue, that would be appreciated. |
draft-ietf-quic-transport.md
Outdated
| disposing of connection state could result in delayed or reordered packets to be | ||
| handled poorly. For endpoints that have some alternative means to ensure that | ||
| that late arriving packets on the connection are discarded, such as closing the | ||
| UDP port, an abbreviated draining period can allow for faster resource recovery. |
There was a problem hiding this comment.
(i) Closing the "port" makes no sense, you probably meant to say "socket".
(ii) Closing the port doesn't ensure that they;re discarded -- this can result in an ICMP message being generated in response. Perhaps say something like "to ensure that late-arriving packets on the connection do not create QUIC state, such as by closing the UDP socket"
draft-ietf-quic-transport.md
Outdated
| that late arriving packets on the connection are discarded, such as closing the | ||
| UDP port, an abbreviated draining period can allow for faster resource recovery. | ||
| Servers that retain an open port for accepting new connections SHOULD NOT exit | ||
| the draining period early. |
There was a problem hiding this comment.
This sentence is good.
This makes the 3RTO timer advisory (SHOULD).
It also adds a note about leaving early. If you can be sure that the other
side isn't going to send you more packets indefinitely, then you can end early
if you are OK with receiving reordered or delayed packets.
I also removed a residual mention of sending ACK frames in this state.
Closes #869.