Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify streams unidirectional vs bidirectional based on stream ID #872

Merged
merged 6 commits into from Oct 30, 2017
Merged

Identify streams unidirectional vs bidirectional based on stream ID #872

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
820dd81
Identify unidirectional streams by the 2nd bit in the stream ID
RyanTheOptimist Oct 12, 2017
5061a15
Address nits
RyanTheOptimist Oct 13, 2017
a9b13de
invert
RyanTheOptimist Oct 13, 2017
4137259
clarify
RyanTheOptimist Oct 13, 2017
0740371
more
RyanTheOptimist Oct 13, 2017
afabe8a
Remove unnecessary language
RyanTheOptimist Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -1859,8 +1859,8 @@ The fields in the MAX_STREAM_ID frame are as follows:
Maximum Stream ID:
: ID of the maximum unidirectional or bidirectional peer-initiated stream ID
for the connection. The limit applies to unidirectional steams if the second
least signification bit of the stream id is 0, and applies to bidirectional
streams if it is 1.
least signification bit of the stream id is 1, and applies to bidirectional
streams if it is 0.

Loss or reordering can mean that a MAX_STREAM_ID frame can be received which
states a lower stream limit than the client has previously received.
Expand Down Expand Up @@ -2478,15 +2478,15 @@ created, it MUST close the connection with error code STREAM_STATE_ERROR.

The second least significant bit differentiates between unidirectional streams
and bidirectional streams. Unidirectional streams always have this bit set to
0 and bidirectional streams have this bit set to 1. As a result the initial
1 and bidirectional streams have this bit set to 0. As a result the initial
stream ID for various stream types is listed below:

| Stream ID | Type |
|:------------|:------------------------------|
| 0x01 | Client Unidirectional |
| 0x02 | Server Unidirectional |
| 0x03 | Client Bidirectional |
| 0x04 | Server Bidirectional |
| 0x01 | Client Bidirectional |
| 0x02 | Server Bidirectional |
| 0x03 | Client Unidirectional |
| 0x04 | Server Unidirectional |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this table is wrong too.


Stream ID 0 (0x0) is reserved for the cryptographic handshake. Stream 0 MUST
NOT be used for application data, and is the first client-initiated stream.
Expand Down