Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile flag bits in frame type table #88

Merged
merged 1 commit into from Dec 17, 2016
Merged

Reconcile flag bits in frame type table #88

merged 1 commit into from Dec 17, 2016

Conversation

MikeBishop
Copy link
Contributor

Trivial change, but not my doc. Table gives bits as "01NTLLMM" while frame definition gives them as "01NULLMM". Since the bit is "Unused," I assume that 'U' is correct?

@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Dec 17, 2016
ianswett
ianswett approved these changes Dec 17, 2016
View reviewed changes
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely correct, thanks for the fix.

@ianswett ianswett merged commit 8018855 into master Dec 17, 2016
@martinthomson martinthomson deleted the ack_flags branch January 11, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeBishop @ianswett