Minimal change for HTTP integers #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended as a part of, or follow-on to, #877.
martinthomson
added a commit
that referenced
this pull request
Oct 18, 2017
This didn't turn out to be that disruptive. I'm somewhat worried that I missed something actually. Given that the changes are small, I think that I would prefer this over #887. The most interesting change here is that extension frame types that mention Stream IDs will have to change. I am not aware of any proposed thus far, so maybe it's not too much of a cost to bear. It further confirms my view that we shouldn't be using Stream IDs at this layer anyway. Based on this, I don't see any need for a middle-ground change. The biggest cost here is in taking the larger Stream ID space, not in taking the integer encoding.
martinthomson
added a commit
that referenced
this pull request
Oct 18, 2017
This didn't turn out to be that disruptive. I'm somewhat worried that I missed something actually. Given that the changes are small, I think that I would prefer this over #887 for #877. The most interesting change here is that extension frame types that mention Stream IDs will have to change. I am not aware of any proposed thus far, so maybe it's not too much of a cost to bear. It further confirms my view that we shouldn't be using Stream IDs at this layer anyway. Based on this, I don't see any need for a middle-ground change. The biggest cost here is in taking the larger Stream ID space, not in taking the integer encoding.
MikeBishop
pushed a commit
that referenced
this pull request
Oct 30, 2017
This didn't turn out to be that disruptive. I'm somewhat worried that I missed something actually. Given that the changes are small, I think that I would prefer this over #887 for #877. The most interesting change here is that extension frame types that mention Stream IDs will have to change. I am not aware of any proposed thus far, so maybe it's not too much of a cost to bear. It further confirms my view that we shouldn't be using Stream IDs at this layer anyway. Based on this, I don't see any need for a middle-ground change. The biggest cost here is in taking the larger Stream ID space, not in taking the integer encoding.
|
Replaced by #888. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't especially like this version, but it is the easiest change to HTTP after we take #877.