Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximal change for HTTP integer encoding #888

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Maximal change for HTTP integer encoding #888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1d5014
Maximal change for HTTP integer encoding
martinthomson Oct 18, 2017
d241018
Missed a few fixed-size integers
martinthomson Oct 18, 2017
200926b
More fixed-size integer residue
martinthomson Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions draft-ietf-quic-http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,9 @@ type HTTP_WRONG_STREAM.

The CANCEL_PUSH frame has no defined flags.

The CANCEL_PUSH frame carries a 32-bit Push ID that identifies the server push
that is being cancelled (see {{frame-push-promise}}).
The CANCEL_PUSH frame carries a Push ID encoded as a variable-length integer.
The Push ID identifies the server push that is being cancelled (see
{{frame-push-promise}}).

If the client receives a CANCEL_PUSH frame, that frame might identify a Push ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a reference to a 32 bit Push ID three lines above this one. I think that needs to be updated as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there were two, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or three; I missed your example, but fixed two others...

that has not yet been mentioned by a PUSH_PROMISE frame.
Expand Down