Remove a redundant sentence #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated recommendation to not stop and restart sending older ack blocks
|
This closes #917. |
|
LGTM, merging. |
|
I'll note that the comment says this adds text on why stopping and then resuming sending older ack blocks is not recommended in response to #917, but it doesn't. Did you mean to add that text? |
janaiyengar
approved these changes
Nov 28, 2017
|
@janaiyengar After further discussion with Mike in person, I decided it'd be better to add text to the recovery doc and make this as straightforward and clear as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add text on why stopping and then resuming sending older ack blocks is not recommended in response to #917