Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't update RTT for ack-only packets #984

Closed
wants to merge 3 commits into from
Closed

Don't update RTT for ack-only packets #984

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28baaa0
Don't update RTT for ack-only packets
martinthomson Dec 5, 2017
81e0bba
Make normative, clearer
martinthomson Dec 5, 2017
2651b66
Use the as-yet-undefined is_ackable()
martinthomson Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,10 +579,11 @@ Pseudocode for OnPacketSent follows:

When an acknowledgment is received, it may acknowledge 0 or more packets.

The first acknowledgment for the largest acknowledged packet is used to update
the estimate of minimum and smoothed RTT. However, if the largest acknowledged
packet would not have caused an acknowledgment to be sent, RTT estimates are not
updated, because the acknowledgment could be significantly delayed.
The first acknowledgment received for the largest acknowledged packet is used to
update the estimate of minimum and smoothed RTT. However, if the largest
acknowledged packet would not have caused an acknowledgment to be sent, RTT
estimates MUST NOT be updated, because the acknowledgment could be significantly
delayed.

Pseudocode for OnAckReceived and UpdateRtt follow:

Expand All @@ -592,7 +593,7 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
// If the largest acked is newly acked and is a packet
// that would normally cause an ack, update the RTT.
if (sent_packets[ack.largest_acked] and
not ack_only(sent_packets[ack.largest_acked])):
is_ackable(sent_packets[ack.largest_acked])):
latest_rtt = now - sent_packets[ack.largest_acked].time
UpdateRtt(latest_rtt, ack.ack_delay)
// Find all newly acked packets.
Expand Down