Minor mods to stream state machine text #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
reviewed
Dec 5, 2017
draft-ietf-quic-transport.md
Outdated
| "open" when either send or receive stream is in a non-terminal state and | ||
| "closed" when both send and receive streams are in a terminal state. | ||
| Implementations might represent the state of the bidirectional stream as a | ||
| composite of the states of the constituent send and receive streams. The |
There was a problem hiding this comment.
nits:
I a prefer lower case 'may' to 'might' in the line above.
Should it states be plural?
I think constituent is unnecessary
| containing a previous STOP_SENDING is lost. However, once either all stream | ||
| data or a RST_STREAM frame has been received for the stream - that is, the | ||
| stream is in any state other than "Recv" or "Size Known" - sending a | ||
| STOP_SENDING frame is unnecessary. |
There was a problem hiding this comment.
Above you changed it so it's SHOULD. Should it be changed here as well?
There was a problem hiding this comment.
I think of this as justification for why it's a SHOULD above, so I'd prefer to leave this text as is.
There was a problem hiding this comment.
SHOULD doesn't make sense here.
janaiyengar
commented
Dec 5, 2017
draft-ietf-quic-transport.md
Outdated
| "open" when either send or receive stream is in a non-terminal state and | ||
| "closed" when both send and receive streams are in a terminal state. | ||
| Implementations might represent the state of the bidirectional stream as a | ||
| composite of the states of the constituent send and receive streams. The |
| containing a previous STOP_SENDING is lost. However, once either all stream | ||
| data or a RST_STREAM frame has been received for the stream - that is, the | ||
| stream is in any state other than "Recv" or "Size Known" - sending a | ||
| STOP_SENDING frame is unnecessary. |
There was a problem hiding this comment.
I think of this as justification for why it's a SHOULD above, so I'd prefer to leave this text as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rewording and added one normative.