Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACK frame packet numbers aren't truncated #999

Merged
merged 1 commit into from
Dec 8, 2017
Merged

ACK frame packet numbers aren't truncated #999

merged 1 commit into from
Dec 8, 2017

Conversation

martinthomson
Copy link
Member

@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Dec 7, 2017
martinduke
martinduke reviewed Dec 7, 2017
View reviewed changes
Copy link
Contributor

@martinduke martinduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement. I might add "...not truncated, but the field may less than 64 bits given enough leading zeroes."

@ekr
Copy link
Collaborator

ekr commented Dec 7, 2017

LGTM

@martinthomson martinthomson merged commit 4279793 into master Dec 8, 2017
@MikeBishop MikeBishop deleted the variable-length-last_acknowledged branch January 21, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinduke martinduke martinduke left review comments

@janaiyengar janaiyengar janaiyengar approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@martinthomson @ekr @janaiyengar @ianswett @martinduke