Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial suggestions from Benjamin Kaduk's IESG Evaluation #76

Merged
merged 2 commits into from Jan 28, 2022

Conversation

kaduk
Copy link
Contributor

@kaduk kaduk commented Jan 28, 2022

No description provided.

Copy link
Contributor

@DavidSchinazi DavidSchinazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, in particular finding the outdated TP name! I like changes 2 and 3 out of 3 but would prefer to skip the first one.

@@ -106,7 +106,7 @@ QUIC, such as for a Virtual Private Network (VPN). Internet-layer tunneling
protocols generally require a reliable and authenticated handshake, followed by
unreliable secure transmission of IP packets. This can, for example, require a
TLS connection for the control data, and DTLS for tunneling IP packets. A single
QUIC connection could support both parts with the use of unreliable datagrams.
QUIC connection could support both parts when unreliable datagrams are available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer the original text here, sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation for any change here is that the original text sounds like the (reliable) control data is being supported by the unreliable datagrams, which seems unlikely to be the expected use.
Other options include "by augmenting reliable streams with unreliable datagrams", "could extend from the former to the latter by using unreliable datagrams", etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about with the use of unreliable datagrams in addition to reliable streams?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sold

Copy link
Contributor

@DavidSchinazi DavidSchinazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DavidSchinazi DavidSchinazi merged commit aba6532 into quicwg:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants