Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CID allocation strategy #325

Closed
Yanmei-Liu opened this issue Mar 21, 2024 · 3 comments
Closed

CID allocation strategy #325

Yanmei-Liu opened this issue Mar 21, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists explicit path ID question Further information is requested

Comments

@Yanmei-Liu
Copy link
Contributor

We need to specify CID allocation strategy in case endpoints doesn't have available CIDs with same unused Path ID to initialize a new path.

Also need to take security into consideration.

Comments from PR#292:

marten-seemann 4 days ago

This seems backwards. Connection IDs are issues for paths, not the other way around.
Also, if I allow you to open 1 million paths, you're probably wise to not issue me 1 million CIDs.

@mirjak
Copy link
Collaborator

mirjak commented May 14, 2024

What do you want to say here @Yanmei-Liu?

I think it simply the case if you don't have a CIDs for an unused path ID, you can't open a new path. However, the other end might purposefully not provide more path IDs. I think you just have to accept it.

If you have CIDs for an unused path ID from the peer but did not provide CIDs for the the same path ID to your peer, you need to do that before opening the path. #315 discusses that already.

What else do we need? or what else would we even be able to say?

@mirjak mirjak added the question Further information is requested label May 14, 2024
@mirjak mirjak added the duplicate This issue or pull request already exists label May 29, 2024
@mirjak
Copy link
Collaborator

mirjak commented May 29, 2024

@Yanmei-Liu can we close this issue and move the discussion to #338 instead?

@mirjak
Copy link
Collaborator

mirjak commented May 29, 2024

Closing please discuss in #338. (Or reopen if that doesn't work)

@mirjak mirjak closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists explicit path ID question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants