Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] Explicit Path ID: Clarify that endpoints use the same Path ID in both directions. #315

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Yanmei-Liu
Copy link
Contributor

@Yanmei-Liu Yanmei-Liu commented Mar 17, 2024

Solving issue #294

@Yanmei-Liu Yanmei-Liu changed the title [+] Clarify that endpoints use the same Path ID in both directions. [+] Explicit Path ID: Clarify that endpoints use the same Path ID in both directions. Mar 17, 2024
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a MUST.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Yanmei-Liu and others added 2 commits March 17, 2024 21:23
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Copy link
Contributor

@qdeconinck qdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to get the story about the PATH_RESPONSE.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Yanmei-Liu and others added 7 commits March 20, 2024 08:52
Co-authored-by: Quentin De Coninck <quentin.deconinck@umons.ac.be>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Quentin De Coninck <quentin.deconinck@umons.ac.be>
@Yanmei-Liu Yanmei-Liu changed the base branch from dev/path_id to main April 1, 2024 03:51
Co-authored-by: Quentin De Coninck <quentin.deconinck@umons.ac.be>
If the server receives a PATH_CHALLENGE before receiving MP_NEW_CONNECTION_ID
for the specific path, it MAY choose to ignore the PATH_CHALLENGE, or it can
choose to send the PATH_RESPONSE frame upon reception of a
MP_NEW_CONNECTION_ID frame containing the corresponding Path ID.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the client should only try to open a path if it had send CIDs for that path ID (and the reception has been ack'ed). Then if the server received a path challenges for a path ID it doesn't have a CID for, it should either be an error or it should send a path abandon on another path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the client should only try to open a path if it had send CIDs for that path ID (and the reception has been ack'ed).

We could be in the situation where the server has sent MP_NEW_CONNECTION_ID frames to the client, and the client wants to open a new path by sending a PATH_CHALLENGE along with a MP_NEW_CONNECTION_ID frame with the associated Path ID.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sending it in the same packet is fine as well because than it cannot be lost or reordered separately.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Copy link
Contributor

@qdeconinck qdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos fixes.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
If the server receives a PATH_CHALLENGE before receiving MP_NEW_CONNECTION_ID
for the specific path, it MAY choose to ignore the PATH_CHALLENGE, or it can
choose to send the PATH_RESPONSE frame upon reception of a
MP_NEW_CONNECTION_ID frame containing the corresponding Path ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the client should only try to open a path if it had send CIDs for that path ID (and the reception has been ack'ed).

We could be in the situation where the server has sent MP_NEW_CONNECTION_ID frames to the client, and the client wants to open a new path by sending a PATH_CHALLENGE along with a MP_NEW_CONNECTION_ID frame with the associated Path ID.

mirjak and others added 3 commits May 17, 2024 11:43
Co-authored-by: Quentin De Coninck <quentin.deconinck@umons.ac.be>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants