Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some guidance for ACK scheduling #129

Merged
merged 2 commits into from Jul 11, 2022
Merged

Add some guidance for ACK scheduling #129

merged 2 commits into from Jul 11, 2022

Conversation

qdeconinck
Copy link
Contributor

Fixes #123.

the peer. However, the sender can be interested by estimating the RTT of
a path instead of the sum of the forward one-way delay of a path and the
return one-way delay of another. To that end, a receiver should
periodically send ACK(_MP) frames on the path they acknowledge packets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending ACK_(MP) frames on the fastest path is one of the ACK scheduling strategies, but IMO the most common strategy is sending ACK_(MP) frames on the same path of the packet was sent. By the way, as QUIC-TRANSPORT doesn't contain a mechanism to calculate one-way-delay on a certain path, it's very important that we need to add some guidance for one-way-delay calculation(e.g. [QUIC-Timestamp]) with the fastest path ACK scheduling strategy, and some guidance for the potential impact on congestion control.

Copy link
Contributor

@Yanmei-Liu Yanmei-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add guidance for one-way-delay calculation and impact on congestion control, if we want to recommend the fastest path ACK scheduling strategy.

@mirjak
Copy link
Collaborator

mirjak commented Jul 11, 2022

I believe we can merge this now as it is. If we want to add more guidance later we should open a separate issue and another PR.

@Yanmei-Liu Yanmei-Liu merged commit dad1f45 into main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guidance on scheduling of packets containing ACK frames
3 participants