Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Abandon frame after NAT rebinding #198

Closed
wants to merge 1 commit into from
Closed

Conversation

mirjak
Copy link
Collaborator

@mirjak mirjak commented Mar 10, 2023

This is the proposed text more the other PR to start working this. The proposed solution in further discussion was to also extend the path abandon path with a specific reason code of this case.

This is the proposed text more the other PR to start working this. The proposed solution in further discussion was to also extend the path abandon path with a specific reason code of this case.
@mirjak
Copy link
Collaborator Author

mirjak commented Mar 10, 2023

See issue #188

Copy link
Contributor

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR is premature. We do not yet have consensus on how to solve issue #188, and we should keep the discussion there.

and did not receive a RETIRED_CONNECTION_ID frame for the old CID yet,
it can send an PATH_ABANDON frame for that CID in order to indicate
that the "old" path is not usable anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really not sure there. First, I think having side effects for PATH_CHALLENGE is a bad idea, as PATH_CHALLENGE is just a connectivity test. Second, I do not understand the mechanism. We understand that if a node only use heuristics, it will sometime fail to identify the old path. If it does identify it, it will send two path challenges per normal NAT rebinding guidance, only the one on the new path will succeeds, and everything will be fixed. But if it does not, it will only send a path challenge on the new path, to confirm continuity. Due to asymmetric knowledge, the peer sees only one path, so the challenge arrives on the existing path. There should be no other action than sending a path response.

@mirjak
Copy link
Collaborator Author

mirjak commented Mar 10, 2023

Yes, this is not ready to merge and discuss should take place in the issue (#188). I just wanted to capture this text as a starting point before we lose it.

@huitema
Copy link
Contributor

huitema commented Feb 20, 2024

I think we need clarity on PR #292 before we progress this draft. We have an issue there, because the "Natted" path and the "before-NAT" path use the same number space. With PR #292, that gives us a strong constraint. I think I explained a plausible solution in #292 (comment), but with that solution if rebinding is accepted the new (natted) path will have the same path_id as before NAT rebinding.

@mirjak
Copy link
Collaborator Author

mirjak commented May 27, 2024

OBE after merge of #292

@mirjak mirjak closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants