Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using 3xmaxPTO between key updates #257

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Jul 6, 2023

Closes #209.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Copy link
Contributor

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify the "PTO" a bit more precisely.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but it’s additional complexity compared to RFC 9001. #215 proposes a different solution that doesn’t require us to do anything differently.

@kazuho
Copy link
Member Author

kazuho commented Jul 6, 2023

@marten-seemann I do not think changing 3PTO to 3maxPTO is a great deal. For existing QUIC stacks using three keys and PN in conjunction, switching to two keys would be a simplification.

Compared to that, it is my opinion that using different keys on each path and running key updates separately as proposed in #215 is an unnecessary complexity.

Copy link
Member Author

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take it or leave it, but we might want to clarify that this value is different from the recommendation that we have in QUIC version 1.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Copy link
Contributor

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the edited version, and I agree with the suggested change.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mirjak mirjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's simpler than the current text, therefore I think we should merge it for now (and potentially keep discussing further changes later).

Copy link
Contributor

@Yanmei-Liu Yanmei-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very clear. Looks good to me.

@qdeconinck qdeconinck merged commit 788d8d5 into quicwg:main Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don’t require sending packets on all paths on key updates
6 participants