Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask people not to drop new versions? #145

Closed
martinduke opened this issue Dec 10, 2020 · 7 comments
Closed

Ask people not to drop new versions? #145

martinduke opened this issue Dec 10, 2020 · 7 comments
Assignees

Comments

@martinduke
Copy link
Contributor

The VN section suggests that observers not use the version number to detect QUIC.

Would it be futile to ask them to admit QUIC versions they don't recognize rather than drop them?

@martinthomson
Copy link
Member

Probably.

@mirjak
Copy link
Contributor

mirjak commented Dec 10, 2020

Not sure. Depends on the function you implement. I guess there could be security functions that decide to only allow certain versions... not sure if that is justified but I don't think we can stop it.

@mirjak
Copy link
Contributor

mirjak commented Dec 17, 2020

Any further opinions here?

@martinduke
Copy link
Contributor Author

We can stop it with greasing, I guess. IMO the draft should specify best practices that don't break extensibility and if people don't follow it it's on them. That's the approach I took in QUIC-LB.

@mirjak
Copy link
Contributor

mirjak commented Dec 17, 2020

The best practice is to not block any unknown traffic as blocking hinders evolution. However, I guess there might be security reasons why some will not do that. I guess allowing for certain versions of QUIC is better than blocking UDP entirely...?

@britram
Copy link
Contributor

britram commented Dec 21, 2020

+1... I don't think that putting text in this document saying "don't wholesale block versions of QUIC you don't understand" will actually change the behavior of the boxes that will ship this behavior, since drop-unknown is taken as a security best practice. But I still think it's worth putting that advice in the document nonetheless, if only to have "I told you so" in an RFC.

(I do still tend to think that we'll see only two behaviors emerge in the wild: (1) permit anything with a QUIC wire image since there's not much to grab on to there (and rely on the LB implementation to eat DoS hiding behind that wire image) and (2) block anything that smells like QUIC (because it is easy to implement in the default case and it forces fallback to TCP, which already has lots of running security monitoring code).)

@britram britram self-assigned this Dec 21, 2020
mirjak added a commit that referenced this issue Dec 21, 2020
@britram
Copy link
Contributor

britram commented Dec 21, 2020

will work up a PR for us to discuss

britram added a commit that referenced this issue Dec 22, 2020
Please don't drop new versions, fix #145.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants