Quic natsupp #171
Merged
Quic natsupp #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with upstream
britram
requested changes
Jan 15, 2021
mirjak
requested changes
Jan 18, 2021
There was a problem hiding this comment.
I would like to have this section a bit more crisp. There is probably some intro text that we don't need in this extent. But more importantly, things to do or not to do should be more clearly stated (as Brian also indicated). Maybe some text can also be moved in the load balancer section; plus double check with other text in this doc, e.g. in the sections on CID and Flow Associations.
Co-authored-by: Brian Trammell <brian@trammell.ch>
Co-authored-by: Brian Trammell <brian@trammell.ch>
Co-authored-by: Brian Trammell <brian@trammell.ch>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
|
I addressed all of the comments except where I had no idea for what to write. As for making the section more "crisp", I would much prefer that we land this PR and have another one composed by someone else who has a firm idea of what to do about it. |
mirjak
reviewed
Jan 20, 2021
mirjak
approved these changes
Jan 20, 2021
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146