Reference VN instead of duplicating it. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From @martinduke review. Fixes #468
martinduke
approved these changes
May 18, 2022
martinthomson
approved these changes
May 18, 2022
|
Not sure if this is the right approach. The whole point of this document is that we don't want the reader ask to read the spec in details but pre-digest the important bits for the reader. |
|
I'm not going to lie down in the road over this, but maybe there's a middle ground? Instead of punting totally to the VN Draft, maybe we can specifically say that VN has a deployment template in that section? |
|
Feel free to create a PR :-) |
|
per discussion with @mirjak on 5 July, keep the new text but add a short but useful summary of version negotiation above it. I'll rework this PR. |
britram
commented
Jul 5, 2022
mirjak
reviewed
Jul 6, 2022
martinduke
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @martinduke review. Fixes #468