Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnknownFrame in QUIC and HTTP/3 events. #201

Closed
LPardue opened this issue May 16, 2022 · 0 comments · Fixed by #224
Closed

UnknownFrame in QUIC and HTTP/3 events. #201

LPardue opened this issue May 16, 2022 · 0 comments · Fixed by #224
Assignees
@LPardue

Comments

@LPardue
Copy link
Member

LPardue commented May 16, 2022

In https://quicwg.org/qlog/draft-ietf-quic-qlog-h3-events.html#appendix-A.3.9 you say

HTTP/3 qlog re-uses QUIC's UnknownFrame definition, since their values and usage overlaps

This is ambiguous to me. Are you saying the defined object - QUIC UnknownFrame - is reused, or that the structure of the object - HTTP/3 `UnknownFrame - is identical.

I think it has to be the latter, because some HTTP/3 events carry HTTPFrame. If this is the case, I would just fully define the frame in the HTTP/3 specification to avoid confusion.
@LPardue LPardue self-assigned this Sep 8, 2022
@LPardue LPardue mentioned this issue Sep 9, 2022
Merged
LPardue added a commit that referenced this issue Sep 9, 2022
@LPardue
Define HTTPUnknownFrame type for H3
6601995 
Avoid confusing use of QUIC's UnknownFrame type.

Fixes #201
LPardue added a commit that referenced this issue Oct 5, 2022
@LPardue
Define HTTPUnknownFrame type for H3 (#224)
10c6619 
Avoid confusing use of QUIC's UnknownFrame type.

Fixes #201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LPardue LPardue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define HTTPUnknownFrame type for H3 quicwg/qlog
1 participant
@LPardue