Make QuicFrame and HTTPFrame into CDDL extension points #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarx
requested review from
marten-seemann,
lnicco and
LPardue
as code owners
LPardue
reviewed
Oct 24, 2022
LPardue
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing the exercise to try and define a new DATAGRAM extension for qlog (at https://github.com/rmarx/draft-marx-quic-qlog-datagram), it became clear that we only had a CDDL extension point for the events themselves (
$ProtocolEventBody) but NOT for the individual QUIC and HTTP/3 frames.This is needed so we can add the CDDL definitions for new frames in other documents and have them properly matched to the CDDL expectations of "main document" events like
http:frame_parsedandtransport:packet_sent.