Take a stab at refactoring the use of Note:.
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a start. While these are editorial changes they will definitely require discussion for how it's best to change each Note:.
LPardue
reviewed
Jan 18, 2023
draft-ietf-quic-qlog-h3-events.md
Outdated
Comment on lines
227
to
229
| This event can contain any number of unspecified fields. This is to | ||
| allow representation of unknown settings like grease settings or parameters of | ||
| non-standard extensions. |
There was a problem hiding this comment.
I think this is what we're trying to say?
Suggested change
| This event can contain any number of unspecified fields. This is to | |
| allow representation of unknown settings like grease settings or parameters of | |
| non-standard extensions. | |
| This event can contain any number of unspecified fields. This | |
| allows for representation of reserved settings (aka grease) or ad-hoc support for extension settings | |
| that do not have a related qlog schema definition . |
draft-ietf-quic-qlog-h3-events.md
Outdated
| @@ -247,7 +246,7 @@ HTTPParametersRestored = { | |||
| ~~~ | |||
| {: #http-parametersrestored-def title="HTTPParametersRestored definition"} | |||
|
|
|||
| Note that, like for parameters_set above, this event can contain any number of | |||
| Similarly to HTTPParametersSet this event can contain any number of | |||
There was a problem hiding this comment.
Suggested change
| Similarly to HTTPParametersSet this event can contain any number of | |
| Similar to HTTPParametersSet, this event can contain any number of |
draft-ietf-quic-qlog-h3-events.md
Outdated
| @@ -247,7 +246,7 @@ HTTPParametersRestored = { | |||
| ~~~ | |||
| {: #http-parametersrestored-def title="HTTPParametersRestored definition"} | |||
|
|
|||
| Note that, like for parameters_set above, this event can contain any number of | |||
| Similarly to HTTPParametersSet this event can contain any number of | |||
| unspecified fields to allow for additional and custom settings. | |||
There was a problem hiding this comment.
Suggested change
| unspecified fields to allow for additional and custom settings. | |
| unspecified fields to allow for reserved or extension settings. |
draft-ietf-quic-qlog-h3-events.md
Outdated
Comment on lines
299
to
300
| This event is logged at the time the frame header is created. A frame payload | ||
| may require multiple write operations that are logged using data_moved events. |
There was a problem hiding this comment.
Suggested change
| This event is logged at the time the frame header is created. A frame payload | |
| may require multiple write operations that are logged using data_moved events. | |
| might extend over multiple write operations, which would be logged using multiple data_moved events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a start. While these are editorial changes they will
definitely require discussion for how it's best to change each Note:.