Convert H3 setting param types to a real type #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
requested review from
rmarx,
marten-seemann and
lnicco
as code owners
rmarx
reviewed
Jan 29, 2024
draft-ietf-quic-qlog-h3-events.md
Outdated
| ? name: H3SettingsName | ||
|
|
||
| ; only when name === "unknown" | ||
| ? type_value: uint64 |
There was a problem hiding this comment.
Nit: Not sure I like type_ here... it isn't called that in 9114 (there it's more identifier) and to align with name above and other similar fields, I'd go with name_value maybe?
There was a problem hiding this comment.
name or identifier seems fine to me. I was checking the IANA table which uses slightly different terms and it threw me off
|
Instead of a separate raw_type field, we'll just allow the nae to be a union of enum and uint64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382