Create ALPNIdentifier type to allow bytes or string presentation #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALPN IDs aren't guaranteed to be safe text, so allow logging the byte sequence. However, don't force endpoint to do that if their willing to do some safety checking or safe encoding. Closes #368
LPardue
requested review from
rmarx,
marten-seemann and
lnicco
as code owners
rmarx
requested changes
Jan 29, 2024
draft-ietf-quic-qlog-quic-events.md
Outdated
| the most optimal one and communicates this back to the client. If not, the | ||
| connection is closed. | ||
| ALPN identifiers are byte sequences, that may be possible to present as UTF-8. | ||
| The `ALPNIDentifier`` type supports either format. |
There was a problem hiding this comment.
Suggested change
| The `ALPNIDentifier`` type supports either format. | |
| The `ALPNIDentifier`` type supports either format. Implementations SHOULD log at least one format, but MAY log both or none. |
Co-authored-by: Robin Marx <rmarx@akamai.com>
Co-authored-by: Robin Marx <rmarx@akamai.com>
rmarx
approved these changes
Jan 29, 2024
marten-seemann
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALPN IDs aren't guaranteed to be safe text, so allow logging the byte
sequence. However, don't force endpoint to do that if their willing
to do some safety checking or safe encoding.
Closes #368