Explain 64-bit I-JSON issues but don't embed that in CDDL #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
requested review from
rmarx,
marten-seemann and
lnicco
as code owners
Alternative to #359. I-JSON can mess with big numbers and we can't constrain the range. We don't want to mandate bigint support on anyone. We don't want to make non-JSON serializers/parsers have to worry about stringified numbers - so modifying the CDDL directly seems off. There's lots of ways that implementations can internally handle values, we don't care much about that here. For interop, settle on allow JSON parsers to write uint64 as strings if they want to. Make it clear that parsers should expect that, unless they have some non-standard way of knowing. Fixes #229
LPardue
force-pushed
the
remove-uint64-cddl-duality
branch
from
57f83fc
to
57f8ac0
Compare
rmarx
requested changes
Feb 5, 2024
Co-authored-by: Robin Marx <rmarx@akamai.com>
|
those suggestions make it better, thanks |
rmarx
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #359.
I-JSON can mess with big numbers and we can't constrain the range.
We don't want to mandate bigint support on anyone. We don't want
to make non-JSON serializers/parsers have to worry about stringified
numbers - so modifying the CDDL directly seems off.
There's lots of ways that implementations can internally handle values,
we don't care much about that here. For interop, settle on allow JSON parsers
to write uint64 as strings if they want to. Make it clear that parsers
should expect that, unless they have some non-standard way of knowing.
Fixes #229